Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for in_parallel. #45

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Add support for in_parallel. #45

merged 4 commits into from
Aug 22, 2024

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Aug 21, 2024 •
edited
Loading

See lostisland/faraday#1584 for context.

Fixes #44.

Types of Changes

  • New feature.

Contribution

@ioquatix ioquatix changed the title Initial implementation (not working). Add support for in_parallel. Aug 21, 2024
@ioquatix ioquatix mentioned this pull request Aug 21, 2024
Merged
2 tasks
iMacTia
iMacTia approved these changes Aug 22, 2024
View reviewed changes
Copy link

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just left a small suggestion on how to deal with different Faraday versions, but that's entirely up to you 🙂
I'll go ahead and cut a new Faraday release with the execute support

lib/async/http/faraday/adapter.rb Outdated Show resolved Hide resolved
@ioquatix ioquatix merged commit 4072275 into main Aug 22, 2024
32 of 40 checks passed
@ioquatix ioquatix deleted the parallel-manager-support branch August 22, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMacTia iMacTia iMacTia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Faraday #in_parallel method
2 participants
@ioquatix @iMacTia